Skip to content

Update: Auth API #115

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Sep 7, 2025
Merged

Update: Auth API #115

merged 3 commits into from
Sep 7, 2025

Conversation

@jbriones1
Copy link
Contributor

@jbriones1 jbriones1 commented Sep 7, 2025

  • Switched to using the DeclarativeBase type from SQLAlchemy for better type checking with PyRight
  • Updated the Auth tables (site_user, user_session) to use ORM mapped values, to remove type errors when comparing Column[...] to Python-typed values
  • Added body and response models to the auth endpoints
  • Added a bunch of typing

@jbriones1 jbriones1 requested a review from p-north September 7, 2025 04:38
p-north
p-north requested changes Sep 7, 2025
View reviewed changes
Copy link
Contributor

@p-north p-north left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

-Looks good, refer to sugestions below

@jbriones1 jbriones1 requested a review from p-north September 7, 2025 21:25
p-north
p-north approved these changes Sep 7, 2025
View reviewed changes
Copy link
Contributor

@p-north p-north left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

-looks good to me

@jbriones1 jbriones1 merged commit c9f6c1e into main Sep 7, 2025
3 checks passed
@jbriones1 jbriones1 deleted the update_auth-api branch September 7, 2025 22:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@p-north p-north p-north approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@jbriones1 @p-north