Remove config files and create alembic workflow #92
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
micahdbak
force-pushed
the
mdb-csss-site-config
branch
10 times, most recently
from
b04ea37 to
843091a
Compare
micahdbak
force-pushed
the
mdb-csss-site-config
branch
5 times, most recently
from
8094512 to
42a1451
Compare
micahdbak
force-pushed
the
mdb-csss-site-config
branch
from
42a1451 to
d7317e9
Compare
EarthenSky
approved these changes
Nov 17, 2024
Collaborator
EarthenSky
left a comment
EarthenSky
left a comment
There was a problem hiding this comment.
looks good, love it!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As per the creation of https://github.com/CSSS/csss-site-config, some configuration files that are directly related to the deployment to the server are now redundant.
We are aiming to make csss-site-backend/csss-site-frontend contain code irrespective of deployment environments, and have csss-site-config contain all configuration and deployment things moving forward, which will make handling multiple repositories a bit easier.
Also, new workflow to make sure that alembic upgrade head successfully happens for pull requests, to prevent broken db migrations.