Santize @ for discord #22
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pbjames
requested review from
MattyTheHacker and
Thatsmusic99
as code owners
Member
Thatsmusic99
left a comment
Thatsmusic99
left a comment
There was a problem hiding this comment.
I'm not sure if we want to remove the @ symbol altogether, an alternative suggested was adding the U+200B character after the symbol which has no visible effect
|
Not sure the problem with removing the @ and replacing it with " at " instead? |
Contributor
Author
|
Yeah i'll do "(at)" since it can be used in correct contexts. |
Thatsmusic99
approved these changes
Dec 13, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Santise mc -> discord messaging by removing "@"