Skip to content

Can't compare relative paths to absolute paths #193

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Nov 10, 2025
Merged

Can't compare relative paths to absolute paths #193

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
a26837a
Can't compare relative paths to absolute paths
mew1033 Nov 7, 2025
6b2ae0b
Use full challenge_file_path
ColdHeat Nov 10, 2025
92ee27c
Fix lint
ColdHeat Nov 10, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 5 additions & 7 deletions ctfcli/cli/challenges.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -653,7 +653,7 @@ def sync(self, challenge: str = None, ignore: Union[str, Tuple[str]] = ()) -> in
if isinstance(ignore, str):
ignore = (ignore,)

config = Config()
_config = Config()
remote_challenges = Challenge.load_installed_challenges()

failed_syncs = []
Expand All @@ -672,9 +672,7 @@ def sync(self, challenge: str = None, ignore: Union[str, Tuple[str]] = ()) -> in
continue

click.secho(
f"Syncing '{challenge_name}' ("
f"{challenge_instance.challenge_file_path.relative_to(config.project_path)}"
f") ...",
f"Syncing '{challenge_name}' (" f"{challenge_instance.challenge_file_path}" ") ...",
fg="blue",
)
try:
Expand Down Expand Up @@ -720,7 +718,7 @@ def deploy(
else:
skipped_deployments.append(challenge_instance)

config = Config()
_config = Config()
with click.progressbar(deployable_challenges, label="Deploying challenges") as challenges:
for challenge_instance in challenges:
click.echo()
Expand Down Expand Up @@ -748,7 +746,7 @@ def deploy(

click.secho(
f"Deploying challenge service '{challenge_name}' "
f"({challenge_instance.challenge_file_path.relative_to(config.project_path)}) "
f"({challenge_instance.challenge_file_path}) "
f"with {deployment_handler.__class__.__name__} ...",
fg="blue",
)
Expand Down Expand Up @@ -816,7 +814,7 @@ def deploy(
click.secho("Success!\n", fg="green")

if len(skipped_deployments) > 0:
click.secho("Deployment skipped (no image specified) for:",fg="yellow")
click.secho("Deployment skipped (no image specified) for:", fg="yellow")
for challenge_instance in skipped_deployments:
click.echo(f" - {challenge_instance}")

Expand Down