Simplify Avionics Shell (UARTCommandHandler)#77
Merged
Conversation
… options in the analog read HAL
…() function size, remove command history feature
…nics into chore/clean-ups
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Summary of Changes
Motivation
Make the codebase easier to maintain, test, and extend, while removing unused or overly complex features.
The
UARTCommandHandlerwas utilizing dynamic memory for the command history, so it's good to eliminate that until it can be re-implemented with a static allocation.Testing
Tested by opening a shell on MARTHA 1.4 and ensuring most things work right
Check all that apply:
Building
Checklist