Skip to content

inconsistent conversationRepository.getAllByTargetUUID calls #1663

@ElectricNroff

Description

@ElectricNroff

const conversations = await conversationRepository.getAllByTargetUUID(review.uuid, options)

whereas other calls in the same file include an isSecretariat argument and perhaps a UUID of a different object, such as:
const conversations = await conversationRepository.getAllByTargetUUID(reviewObject.target_object_uuid, isSecretariat, options)

Omitting isSecretariat is not compatible with:

async getAllByTargetUUID (targetUUID, isSecretariat, options = {}) {
const conversations = await ConversationModel.find({ target_uuid: targetUUID }, null, options)
return conversations.map(convo => convo.toObject()).filter(conv => isSecretariat || conv.visibility === 'public')
}

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    Status

    Low Priority

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions