Skip to content

Resolves issue #1671, parseError handling in registryUser routing#1779

Merged
david-rocca merged 1 commit intov2.8.0_featurefrom
af-1671
Apr 29, 2026
Merged

Resolves issue #1671, parseError handling in registryUser routing#1779
david-rocca merged 1 commit intov2.8.0_featurefrom
af-1671

Conversation

@afoote-mitre
Copy link
Copy Markdown
Collaborator

Closes Issue #1671

Summary

parseError had been commented out in the registryUser routing, as the function hadn't even been defined yet. Uncommented the references, defined the parseError function in the middleware, and added new tests to ensure the parseError calls are functioning as expected.

Important Changes

src/controller/registry-user.controller/index.js

  • Uncommented parseError calls

src/controller/registry-user.controller/registry-user.middleware.js

  • Added parseError function that wasn't existing, this uses the errors defined in the RegistryOrgControllerError class, as we were already using that class for User related errors elsewhere

test/integration-tests/registry-user/registryUserCRUDTest.js

  • Added tests to ensure parseError correctly fails invalid requests before they make it to the controller

Testing

Steps to manually test updated functionality, if possible

  • 1) Run npm run test:integration and ensure all tests pass

Notes

  • There was no existing testing defined for registryUser. I added ones relevant to this ticket but we should create a ticket to test the rest of the registryUser endpoints, if that ticket doesn't already exist.

@afoote-mitre afoote-mitre self-assigned this Apr 23, 2026
@david-rocca david-rocca changed the base branch from v2.7.6_feature to v2.8.0_feature April 29, 2026 17:10
@david-rocca david-rocca merged commit c29aa48 into v2.8.0_feature Apr 29, 2026
8 of 9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants