Skip to content

Resolves Issue #1773, Additional Validation of User Authorization on Conversation Edits#1808

Merged
david-rocca merged 2 commits into
v2.8.0_featurefrom
af-1773
May 14, 2026
Merged

Resolves Issue #1773, Additional Validation of User Authorization on Conversation Edits#1808
david-rocca merged 2 commits into
v2.8.0_featurefrom
af-1773

Conversation

@afoote-mitre
Copy link
Copy Markdown
Collaborator

Closes Issue #1773

Summary

Conversation edits didn't properly differentiate between a regular user and a Secretariat user, preventing Secretariat users from editing or moderating a conversation that they didn't author. We now check isSecretariat as part of the authorization evaluation, to allow them to edit/moderate as expected.

Additionally, users that were no longer part of an org but still had a valid token, could edit old conversations that they were previously a part of. We now check the org associated with the user's active session against the org that owns the conversation itself. If there is a mismatch, the user is not allowed to make edits.

Important Changes

src/controller/registry-org.controller/registry-org.controller.js

  • Updated authorization to check for isSecretariat to ensure that Secretariat users can edit or moderate any conversation
  • Updated authorization to compare the org associated with the user's active session, against the conversation owning org

Testing

Steps to manually test updated functionality, if possible

  • 1) Run npm run test:integration and ensure all tests pass

@afoote-mitre afoote-mitre requested a review from david-rocca May 12, 2026 19:51
@afoote-mitre afoote-mitre self-assigned this May 12, 2026
@afoote-mitre afoote-mitre marked this pull request as draft May 12, 2026 19:53
@afoote-mitre afoote-mitre changed the base branch from dev to v2.8.0_feature May 12, 2026 19:54
@afoote-mitre afoote-mitre marked this pull request as ready for review May 12, 2026 19:59
@david-rocca david-rocca merged commit 4778497 into v2.8.0_feature May 14, 2026
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants