Skip to content

Conversation

@joshuanapoli
Copy link
Member

@joshuanapoli joshuanapoli commented Dec 8, 2025

Set all the metadata, in order to actually recognize the package as MIT-licensed.

Testing

License-checking passed.

Screenshot 2025-12-08 at 1 26 15 PM

@linear
Copy link

linear bot commented Dec 8, 2025

PD1-323 Standardize Python repos to use mypy and ruff

Standardize on Python 14. TensorFlow projects may need to use Python 13, instead.

Ruff replaces several linters and formatters:

  • black
  • flake8
  • trailing-whitespace
  • end-of-file-fixer
  • isort

Change:

@gemini-code-assist
Copy link
Contributor

Summary of Changes

Hello @joshuanapoli, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request addresses an issue where the package's MIT license was not being properly recognized on PyPI. It resolves this by explicitly adding the license-files metadata to the pyproject.toml configuration. Additionally, the package version has been updated to reflect these changes.

Highlights

  • PyPI License Recognition: Added "license-files = ['LICENSE']" to pyproject.toml to ensure the package is correctly recognized as MIT-licensed on PyPI.
  • Package Version Update: Incremented the package version from "1.4.1" to "1.4.2" in pyproject.toml.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request correctly adds the license-files metadata to pyproject.toml, which will ensure the license is properly recognized by PyPI and included in the package distributions. The version bump is also appropriate for this change. While the change itself is correct, I've identified a significant structural issue in pyproject.toml regarding dependency management with Poetry, which could impact project maintainability and the developer setup experience. I have left a detailed comment on this matter.

"pyarrow>=22.0.0",
]
license = "MIT"
license-files = ['LICENSE']
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

high

While this line correctly adds the license file to the package metadata, I've noticed a larger structural issue in this file. The project is configured to use Poetry as its build backend, but the dependencies are declared under the [project] table.

Poetry's dependency management tools (e.g., poetry install, poetry add) do not use the [project.dependencies] field. They expect dependencies to be defined in [tool.poetry.dependencies]. This discrepancy can lead to an inconsistent or broken development environment, as developers using Poetry commands won't have the correct dependencies installed.

To ensure project maintainability and a consistent developer experience, I strongly recommend moving the dependencies to the [tool.poetry] section in a follow-up change. You would remove the dependencies and requires-python keys from [project] and create a [tool.poetry.dependencies] section like this:

[tool.poetry.dependencies]
python = ">=3.10"
pydantic = ">=2.12.0"
pyarrow = ">=22.0.0"

@joshuanapoli joshuanapoli marked this pull request as ready for review December 8, 2025 18:24
@joshuanapoli joshuanapoli requested a review from alok27a December 8, 2025 18:26
Copy link
Contributor

@alok27a alok27a left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, LGTM!

@joshuanapoli joshuanapoli merged commit ecfbb4c into main Dec 8, 2025
11 checks passed
@joshuanapoli joshuanapoli deleted the jn/license branch December 8, 2025 22:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants