the run method mutates the provided fact

[antoniopresto]

https://github.com/CacheControl/json-rules-engine/blob/master/src/engine.js#L213

I'll send a PR.

[CacheControl]

@antoniopresto Is this causing a problem, or is this a general "remove mutation to improve code base health" kind of issue?

[antoniopresto]

this is causing a problem, adding one unknown field to my form state.

[CacheControl]

@antoniopresto were you able to figure this out? At first I thought your comment meant that there was a bug where the success-events facts was returning an undefined value, but having reviewed the code I don't see how that's possible, since it's initialized as an empty array. Perhaps you were adding all the runtime facts to your form state, and seeing the success-events fact appear was unexpected?

[antoniopresto]

Sorry @CacheControl, I was very busy when I wrote the description and it looks really bad.

The problem is that the run method is modifying the original object received as runtimeFacts.

const myFormState = { name: 'Antonio' };

await engine.run(myFormState)

console.log(Object.keys(myFormState)); // ['name', 'success-events'] <-- 'success-events' was added 

[ks-amit]

Any progress on this?

[calpa]

This cause Uncaught TypeError: Cannot add property success-events, object is not extensible, which is so strange...

[CacheControl]

This bug is fixed in v6.0.0. See changelog