Make compatible with IE8 #102
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add comment explaining for() loop rational
Owner
|
@knalbandianbrightgrove nice! I will merge this today and cut a new version. |
Contributor
Author
|
@CacheControl Thank you, I appreciate it |
Owner
|
@knalbandianbrightgrove no, thank YOU! This is published as 2.3.1 cheers! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi @CacheControl !
I've already make single PR to make IE8 friendly version of your awesome project.
Don't you mind if we'll use "for" loop instead of Array.forEach? That's very important for me as I can't use polyfills in my project.
Looking forward to your decision,
Best regards!