Skip to content

Make compatible with IE8 #102

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Dec 3, 2018
Merged

Make compatible with IE8 #102

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
938d131
Make compatible with IE8
professorkolik Dec 3, 2018
c91581b
Update rule.js
CacheControl Dec 3, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 4 additions & 2 deletions src/rule.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -206,7 +206,9 @@ class Rule extends EventEmitter {
}
let orderedSets = this.prioritizeConditions(conditions)
let cursor = Promise.resolve()
orderedSets.forEach((set) => {
// use for() loop over Array.forEach to support IE8 without polyfill
for (let i = 0; i < orderedSets.length; i++) {
let set = orderedSets[i]
let stop = false
cursor = cursor.then((setResult) => {
// after the first set succeeds, don't fire off the remaining promises
Expand All @@ -225,7 +227,7 @@ class Rule extends EventEmitter {
// all conditions passed; proceed with running next set in parallel
return evaluateConditions(set, method)
})
})
}
return cursor
}

Expand Down