profiles/handhelds: Be more specific when matching for MSI Claw#214
Merged
vnepogodin merged 1 commit intomasterfrom Feb 28, 2026
Merged
profiles/handhelds: Be more specific when matching for MSI Claw#214vnepogodin merged 1 commit intomasterfrom
vnepogodin merged 1 commit intomasterfrom
Conversation
ptr1337
approved these changes
Feb 7, 2026
There was a problem hiding this comment.
Pull request overview
Adjusts handheld device detection to avoid false positives by tightening the MSI Claw product-name matching logic in the handheld PCI profiles.
Changes:
- Removes MSI model suffixes (
A2VM/A1M) from the generic handheldhwd_product_name_pattern. - Replaces the MSI Claw profile’s broad suffix match with an anchored, more specific
product_nameregex.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
1Naim
force-pushed
the
fix/claw-false-pos
branch
from
d2edb1a to
80aa5f6
Compare
A certain MSI laptop [1] also has the string "AV2M" in its product name, making it falsely detected as a handheld. Exactly match the Claws' product name in the regex and remove AV2M|A1M from the generic list. [1] https://www.msi.com/Business-Productivity/Summit-13-AI-Plus-Evo-A2VMX/Specification Signed-off-by: Eric Naim <dnaim@cachyos.org>
1Naim
force-pushed
the
fix/claw-false-pos
branch
from
80aa5f6 to
14105af
Compare
1Naim
added a commit
that referenced
this pull request
Mar 15, 2026
Intel Claw devices were removed from the generic list because of false positives. However, the packages key was never added to the claw profile, so new installs don't get correct packages. Add it back to fix this. Fixes: 405f022 ("profiles/handhelds: Be more specific when matching for MSI Claw (#214)") Signed-off-by: Eric Naim <dnaim@cachyos.org>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A certain MSI laptop [1] also has the string "AV2M" in its product name, making it falsely detected as a handheld. Exactly match the Claws' product name in the regex and remove AV2M|A1M from the generic list.
[1] https://www.msi.com/Business-Productivity/Summit-13-AI-Plus-Evo-A2VMX/Specification