Fixing managers actions not taking action#6901
Merged
TheWitness merged 1 commit intoCacti:1.2.xfrom Mar 28, 2026
Merged
Conversation
TheWitness
requested review from
bmfmancini,
browniebraun,
Copilot,
netniV and
xmacan
xmacan
approved these changes
Mar 28, 2026
Contributor
There was a problem hiding this comment.
Pull request overview
This PR addresses SNMP Notification Receiver “actions” in managers.php so that bulk operations (delete/enable/disable) actually apply to the selected managers.
Changes:
- Fixes the POST variable used to read the selected receiver IDs during bulk actions (
selected_itemsvs an incorrect key). - Adjusts the post-action redirect target after applying receiver actions.
- Minor formatting/whitespace cleanups in a few output blocks.
| } | ||
|
|
||
| header('Location: managers.php?header=false'); | ||
| header('Location: managers.php'); |
There was a problem hiding this comment.
This redirect drops the header=false suppression even though the form submission is AJAXified by form_end() (it always posts to ...&header=false). Following the redirect will therefore fetch the full page chrome unnecessarily and is inconsistent with other redirects in this file (e.g. form_save() and the no-selection branch). Consider redirecting to managers.php?header=false (or using appendHeaderSuppression()) to keep the response lightweight and consistent for in-console navigation.
Suggested change
| header('Location: managers.php'); | |
| header('Location: managers.php?header=false'); |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.