Renaming functions due to name space collision#76
Merged
TheWitness merged 1 commit intomainfrom Feb 14, 2026
Merged
Conversation
browniebraun
approved these changes
Feb 14, 2026
Contributor
There was a problem hiding this comment.
Pull request overview
This PR renames the data_edit() helper function in several Servcheck UI pages to avoid PHP global function namespace collisions during request execution.
Changes:
- Renames
data_edit()todata_test_edit()inservcheck_test.php - Renames
data_edit()todata_proxy_edit()inservcheck_proxy.php - Renames
data_edit()todata_credential_edit()inservcheck_credential.php - Renames
data_edit()todata_ca_edit()inservcheck_ca.php
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 4 comments.
| File | Description |
|---|---|
| servcheck_test.php | Updates the edit action handler and function name to avoid data_edit() collisions. |
| servcheck_proxy.php | Renames the edit helper function and its call site for proxy editing. |
| servcheck_credential.php | Renames the edit helper function and its call site for credential editing. |
| servcheck_ca.php | Renames the edit helper function and its call site for CA certificate editing. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.