Skip to content

Renaming functions due to name space collision#76

Merged
TheWitness merged 1 commit intomainfrom
data_edit
Feb 14, 2026
Merged

Renaming functions due to name space collision#76
TheWitness merged 1 commit intomainfrom
data_edit

Conversation

@TheWitness
Copy link
Member

No description provided.

Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR renames the data_edit() helper function in several Servcheck UI pages to avoid PHP global function namespace collisions during request execution.

Changes:

  • Renames data_edit() to data_test_edit() in servcheck_test.php
  • Renames data_edit() to data_proxy_edit() in servcheck_proxy.php
  • Renames data_edit() to data_credential_edit() in servcheck_credential.php
  • Renames data_edit() to data_ca_edit() in servcheck_ca.php

Reviewed changes

Copilot reviewed 4 out of 4 changed files in this pull request and generated 4 comments.

File Description
servcheck_test.php Updates the edit action handler and function name to avoid data_edit() collisions.
servcheck_proxy.php Renames the edit helper function and its call site for proxy editing.
servcheck_credential.php Renames the edit helper function and its call site for credential editing.
servcheck_ca.php Renames the edit helper function and its call site for CA certificate editing.

@TheWitness TheWitness merged commit c35d7ed into main Feb 14, 2026
10 checks passed
@TheWitness TheWitness deleted the data_edit branch February 14, 2026 16:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants