Fix even/odd classes for rows in the syslog report#100
Merged
netniV merged 1 commit intoCacti:developfrom Dec 18, 2019
Merged
Conversation
netniV
requested changes
Dec 16, 2019
Member
netniV
left a comment
netniV
left a comment
There was a problem hiding this comment.
Looks good, add an entry into the README.md to comment on the change.
netniV
approved these changes
Dec 17, 2019
Member
netniV
left a comment
netniV
left a comment
There was a problem hiding this comment.
Thanks, needs an issue number though, likely 100 if you only have the pull request open.
netniV
requested changes
Dec 17, 2019
Member
netniV
left a comment
netniV
left a comment
There was a problem hiding this comment.
Thanks, needs an issue number though, likely 100 if you only have the pull request open.
Only even classes are used. Fix resolves to correct usage of even/odd clases for even/odd rows within the report
netniV
approved these changes
Dec 18, 2019
aleksashka
added a commit
to aleksashka/plugin_syslog
that referenced
this pull request
Dec 20, 2019
Fix even/odd classes for rows in the syslog report (Cacti#100)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Previously all rows in the syslog report had class="even", now even and odd classes alternate correctly.