fix: #203 - Replace INFO is wrong syntax and .gitignore#220
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Fixes a SQL syntax bug where REPLACE INFO was used instead of REPLACE INTO in the weathermap settings save function, and adjusts .gitignore patterns.
Changes:
- Correct
REPLACE INFO→REPLACE INTOin three SQL statements inweathermap_setting_save(). - Update
.gitignoreto useconfigs/**andoutput/**glob patterns.
Reviewed changes
Copilot reviewed 1 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| weathermap-cacti-plugin-mgmt.php | Fixes SQL typo preventing settings from being persisted. |
| .gitignore | Changes ignore patterns from directory form to /** glob form. |
xmacan
approved these changes
May 15, 2026
bmfmancini
approved these changes
May 15, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes: #203