Curvepoints fix causing plugin to be disabled#222
Merged
Conversation
bmfmancini
approved these changes
May 16, 2026
Contributor
There was a problem hiding this comment.
Pull request overview
This PR addresses a PHP 8+ compatibility issue where count() was being called on a non-countable curvepoints value, which could trigger a fatal TypeError and cause Cacti to disable the weathermap plugin during CMDPHP execution.
Changes:
- Initialize
WeatherMapLink::$curvepointsas an empty array to ensure it is always countable. - Replace
count()/sizeof()calls with Cacti-safe helpers (cacti_count(),cacti_sizeof()) inWeatherMapLinkwhere non-arrays could otherwise trigger fatal errors. - Minor formatting/cleanup in curve calculation helpers (
calc_curve,calc_straight) for consistency (no behavioral change intended).
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| lib/WeatherMapLink.class.php | Ensures curvepoints/vialist are handled as countable structures and uses Cacti-safe counting helpers to prevent PHP 8+ fatal errors. |
| lib/WeatherMap.functions.php | Minor formatting/return-style cleanup in curve helper functions; no functional logic changes. |
xmacan
approved these changes
May 16, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is an additional fix to #219 where the count function was failing due to the curvepoints variable not being a countable object, in other words, not being an array. This error would be ignored in earlier versions of PHP.