-
Notifications
You must be signed in to change notification settings - Fork 390
Support for text rendering #106
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Codecov Report
@@ Coverage Diff @@
## master #106 +/- ##
==========================================
+ Coverage 94.21% 94.26% +0.04%
==========================================
Files 19 19
Lines 3889 3922 +33
==========================================
+ Hits 3664 3697 +33
Misses 225 225
Continue to review full report at Codecov.
|
|
@adam-urbanczyk you are on FIRE! Its great to see this actually happen. I love the API as you have it, and id recommend merging this. However, i have some insight to share for future work. TL;DR, you might consider implementing the output on a per-character basis, even though as the API is now, you do not have to. More about that:... It just so happens that i developed a text plugin for onshape. As a part of that, i learned a lot about what users want from a CAD text package. There's a list of features that are necessary to be 'perfect' at least based on the user base I was working with:
I mention all this because when faced with all of those requirements, even though the user simply types in the text they want, I actually generated the output one character at a time,because you have to when you consider the above requirements. You can see some examples here: http://store.parametricparts.com/store/p10/CURVED-TEXT-2.0.html have a look specifically at the input dialog, which shows all the options I ended up with. |
|
@dcowden cool plugin! On OCC level it is possible to render on per-character basis. I'll leave the features you mentioned for another PR though. I think implementing everything would take quite some effort. |
|
Alright, thanks for all your feedback. Merging. |
* Extrude with both=True fix (#321) Extrude with both=True will result in a single solid. * combineWithBase fix * Allow to self-fuse a compound * Formatting fix * Test if extrude with both=True fuses the solids * Fixed version number that was missed during RC2 release. * Prepare for the 2.0 release * Add reference to #106 * Typo fix * Added info about breaking changes * Fixed a typo Co-authored-by: Jeremy Wright <wrightjmf@gmail.com>

This will resolve #48