Extrude with both=True fix #321
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
Codecov Report
@@ Coverage Diff @@
## master #321 +/- ##
=======================================
Coverage 95.38% 95.38%
=======================================
Files 19 19
Lines 4701 4707 +6
=======================================
+ Hits 4484 4490 +6
Misses 217 217
Continue to review full report at Codecov.
|
adam-urbanczyk
changed the title
Member
Author
|
It is ready @jmwright , the only question is if it should be merged before or after 2.0 . |
jmwright
approved these changes
Apr 16, 2020
Member
jmwright
left a comment
jmwright
left a comment
There was a problem hiding this comment.
@adam-urbanczyk Looks good, thanks for putting this together. I feel like this is probably ok to include in the 2.0 release.
Member
Author
|
Alright, merging. |
adam-urbanczyk
added a commit
that referenced
this pull request
Apr 24, 2020
* Extrude with both=True fix (#321) Extrude with both=True will result in a single solid. * combineWithBase fix * Allow to self-fuse a compound * Formatting fix * Test if extrude with both=True fuses the solids * Fixed version number that was missed during RC2 release. * Prepare for the 2.0 release * Add reference to #106 * Typo fix * Added info about breaking changes * Fixed a typo Co-authored-by: Jeremy Wright <wrightjmf@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Will resolve #320