-
Notifications
You must be signed in to change notification settings - Fork 396
Parametric curves support #110
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Codecov Report
@@ Coverage Diff @@
## master #110 +/- ##
==========================================
+ Coverage 94.26% 94.29% +0.02%
==========================================
Files 19 19
Lines 3922 3942 +20
==========================================
+ Hits 3697 3717 +20
Misses 225 225
Continue to review full report at Codecov.
|
|
I think it is ready for review. I made quite some changes to the spline function so please take a good look. I also added one example to the docs. |
jmwright
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good. You're adding even more exiting functionality.
|
+1 for this, looks great and adds hotness too. |
dcowden
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks good to me
|
@dcowden +1 for hotness : ). Merging. |
This will resolve #91 . Also in principle #37 could be solved by this PR.
Sneak preview of the functionality: