Skip to content

Conversation

@adam-urbanczyk
Copy link
Member

@adam-urbanczyk adam-urbanczyk commented Apr 5, 2020

Will resolve #303

  • Add __iter__ to Compound
  • Refactor bool ops in shapes.py
  • Refactor bool ops in cq.py
  • Add tests

Additionally, this PR speeds up bool operation for some cases, e.g. repetitive patterns. It should at least partially solve #183 as well.

@adam-urbanczyk adam-urbanczyk mentioned this pull request Apr 6, 2020
@codecov
Copy link

codecov bot commented Apr 6, 2020

Codecov Report

Merging #312 into master will increase coverage by 0.09%.
The diff coverage is 94.59%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #312      +/-   ##
==========================================
+ Coverage   95.27%   95.36%   +0.09%     
==========================================
  Files          18       18              
  Lines        4636     4685      +49     
==========================================
+ Hits         4417     4468      +51     
+ Misses        219      217       -2     
Impacted Files Coverage Δ
cadquery/cq.py 93.99% <86.66%> (+0.43%) ⬆️
cadquery/occ_impl/shapes.py 90.78% <94.73%> (+0.09%) ⬆️
tests/test_cadquery.py 99.20% <100.00%> (+0.01%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8062b10...0276a8f. Read the comment docs.

@adam-urbanczyk adam-urbanczyk changed the title Bool op refactoring [WIP] Bool op refactoring Apr 6, 2020
@adam-urbanczyk adam-urbanczyk requested a review from jmwright April 6, 2020 19:24
@adam-urbanczyk
Copy link
Member Author

I think it is ready for merging, please take a look @jmwright .

@jmwright
Copy link
Member

jmwright commented Apr 7, 2020

@adam-urbanczyk Thanks!

I'm starting to get a little numb to codecov, which is unfortunate. It doesn't seem to evaluate the code coverage correctly and/or warns about changes that are so minuscule that they don't matter.

@jmwright jmwright merged commit d17d27d into master Apr 7, 2020
@jmwright jmwright deleted the adam-urbanczy-boolop-fix branch October 28, 2025 20:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

newObject and cut() method

3 participants