Skip to content

Conversation

@jmwright
Copy link
Member

This addresses #315 and goes with this draft release.

@adam-urbanczyk Please take a look to see if I've missed anything.

@jmwright jmwright requested a review from adam-urbanczyk April 18, 2020 02:57
@codecov
Copy link

codecov bot commented Apr 18, 2020

Codecov Report

Merging #325 into master will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #325   +/-   ##
=======================================
  Coverage   95.38%   95.38%           
=======================================
  Files          19       19           
  Lines        4707     4707           
=======================================
  Hits         4490     4490           
  Misses        217      217           
Impacted Files Coverage Δ
cadquery/__init__.py 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 19b4dd3...6a5dd93. Read the comment docs.

@adam-urbanczyk
Copy link
Member

Looks good but I'll have another pass. Two missing things I spotted:

  1. Text support
  2. Add section about deprecations and breaking changes (e.g. upcoming workplane center option change).

Copy link
Member

@adam-urbanczyk adam-urbanczyk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I added few things. Feel free to change the wording (my English might be sloppy).

@jmwright
Copy link
Member Author

@adam-urbanczyk Thanks. I fixed one additional typo. Once all the checks pass I'll merge this, create the git tag, then finish/publish the release.

@jmwright jmwright merged commit b81319a into master Apr 24, 2020
@adam-urbanczyk
Copy link
Member

Thanks @jmwright !

@jmwright jmwright deleted the v2.0-update branch February 25, 2021 22:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants