Reported by Ben McClure | September 12th, 2011 @ 12:59 PM
Just starting to check out the Users plugin, and so far I really like what I see.
The first thing that strikes me as odd, however, is the name of the 'details' table.
Wouldn't it be more ideal to name it user_details, both to indicate its actual purpose, and to avoid naming conflicts with any other application or plugin which might have a more generic use for the 'details' table? DetailsController and Detail aren't as big of an issue, because they are at least namespaced inside the plugin, though I still think it would make more sense to go with UserDetailsController and UserDetail for clarity's sake.
I realize it's easy enough to change, but I wasn't sure if there was any particular reasoning behind using such a generic name for such a specific purpose :)
Thanks!
Ben
Reported by Ben McClure | September 12th, 2011 @ 12:59 PM
Just starting to check out the Users plugin, and so far I really like what I see.
The first thing that strikes me as odd, however, is the name of the 'details' table.
Wouldn't it be more ideal to name it user_details, both to indicate its actual purpose, and to avoid naming conflicts with any other application or plugin which might have a more generic use for the 'details' table? DetailsController and Detail aren't as big of an issue, because they are at least namespaced inside the plugin, though I still think it would make more sense to go with UserDetailsController and UserDetail for clarity's sake.
I realize it's easy enough to change, but I wasn't sure if there was any particular reasoning behind using such a generic name for such a specific purpose :)
Thanks!
Ben