minor tweeks#1
Closed
bmilesp wants to merge 11 commits into
Closed
Conversation
modified add/edit views in admin to work out of the box
|
Please pull these commits :) |
|
I've cherry picked two of the commits the others should be obsolete by the recent changes in the develop branch. If I'm wrong please create another pull requests for the changes against the develop branch. Thanks! |
Closed
steinkel
pushed a commit
that referenced
this pull request
Jan 18, 2018
Remove unnecessary translation strings
steinkel
pushed a commit
that referenced
this pull request
Mar 3, 2020
Closed
jeanvier
added a commit
to jeanvier/users
that referenced
this pull request
May 7, 2026
Cake\ORM\Query is a class_alias of Cake\ORM\Query\SelectQuery in Cake 5, so the legacy import worked at autoload time but PHP's parameter type checks at the Cake\ORM\BehaviorRegistry::callFinder() entry point report the canonical class name (SelectQuery) and reject the alias name (Query) used in the behavior signatures: TypeError: CakeDC\\Users\\Model\\Behavior\\OneTimeLoginLinkBehavior::findByOneTimeToken(): Argument CakeDC#1 ($query) must be of type Cake\\ORM\\Query, Cake\\ORM\\Query\\SelectQuery given This blows up on every request that goes through the OneTimeToken authenticator (cakedc/auth) because the authenticator calls $users->loginWithToken($token) on every authenticated request, which internally fires find('byOneTimeToken') and dispatches to the behavior finder. Switch the import to Cake\\ORM\\Query\\SelectQuery and update the two finder signatures + their docblocks to match. Keeps behaviour identical, fixes the TypeError.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.