fix: remove redundant null-coalescing on always-set array offsets in SocialBehavior#1181
Merged
steinkel merged 2 commits into16.next-cake5from May 7, 2026
Merged
Conversation
…SocialBehavior PHPStan flags $userData['first_name'] ?? null and $userData['username'] ?? null as always-existing keys that cannot be null at those code paths.
…compatibility ReCaptcha\Response is declared readonly in newer versions, which prevents PHPUnit from doubling it. Use the public constructor directly instead.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
SocialBehavior::_populateUser()that were blocking the CI pipeline on16.next-cake5$userData['first_name'](line 208) is always set by both branches of the preceding if/else block —?? nullis redundant$userData['username'](line 215) is always set earlier in the same block —?? nullis redundantTest plan