perf-record --call-graph support (x64-only)#1397
Merged
Merged
Conversation
Assisted-by: Claude:claude-opus-4-7
Assisted-by: Claude:claude-opus-4-7
Assisted-by: Claude:claude-opus-4-7
Assisted-by: Claude:claude-opus-4-7
- swapped rsp and rbp numbers - add bitmap for GC Hopefully no more segfaults :) Assisted-by: Claude:claude-opus-4-7
Some of them started to leak into backendProof which I wasn't a fan of.
Some cheats, which I suspect have to do with showing that perf_call stays F. It also bets on comp_no_shmemop and compile_word_to_stack_no_share_inst not needing perf = F.
- comp_no_shmemop - compile_word_to_stack_no_share_inst
Assisted-by: Claude:claude-opus-4-7
Assisted-by: Claude:claude-opus-4-7
- Reducing diffs - Adjusting comments
Thanks to @tanyongkiam for pointing it out
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Passing
--perf_callgraph=Tto the CakeML compiler (x64-only) generates an unverified binary that can be profiled withperf record --call-graph fp.The in-logic compiler uses the default config in
x64_config.Thus, to profile binaries such as checkers, the Dafny compiler, the Scheme compiler, etc., it is necessary to set
perf_calls:=Tin the configuration ultimately used by the compiler.