Fix reverse flag comparison typo in scroll options equality#909
Merged
Caldis merged 1 commit intoCaldis:masterfrom Apr 21, 2026
Merged
Fix reverse flag comparison typo in scroll options equality#909Caldis merged 1 commit intoCaldis:masterfrom
Caldis merged 1 commit intoCaldis:masterfrom
Conversation
Owner
|
感谢帮助修复这个问题 ! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fix a typo in
OPTIONS_SCROLL_DEFAULTequality comparison.What changed
l.reversewithr.reverseinstead ofr.smoothWhy it matters
The current
Equatableimplementation compares the reverse-scroll flag on the left-hand side against the smooth-scroll flag on the right-hand side. That can produce incorrect equality results when scroll option snapshots are compared.Validation