Skip to content
This repository was archived by the owner on Apr 22, 2020. It is now read-only.

Conversation

@blschatz
Copy link

This patch enables creation of HDT's from turtle RDF files.
Compiles the Serd parser in the extension.
Also includes a fix for the recent search regression.

@Callidon
Copy link
Owner

  1. What do you call "a regression in search"?
  2. You pull request doesn't build on Travis, as you have not included ser installation. Please fix it.
  3. Add unit tests for testing the new functionalities you added.

…e HDT.

Add download of serd to travis configuration.
@blschatz
Copy link
Author

Commit faaab97 redefined search using the searchIDs() function rather than the hdt->search(). The searchID's function doesn't check the result of stringToTripleID(), which results in missing strings matching *. Please see the PR for the fix.

serd-0.30.0/src//serdi.c:58:3: error: ‘for’ loop initial declarations are only allowed in C99 mode
   for (const Syntax* s = syntaxes; s->name; ++s) {
   ^
error: command 'gcc' failed with exit status 1
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants