-
Notifications
You must be signed in to change notification settings - Fork 50
Vault: read-only API completeness (get_meta, balance, get_max_deduct, etc.) #112
Copy link
Copy link
Open
Labels
Stellar WaveIssues in the Stellar wave programIssues in the Stellar wave programsecuritysmart-contractssorobanvault
Description
Description
Ensure documented view functions exist, return stable types for SDK consumers, and fail consistently if uninitialized.
Requirements and context
- Views must not mutate storage.
- Align naming with README and backend expectations.
Suggested execution
- Fork the repo and create a branch:
git checkout -b chore/vault-read-api - Implement changes in the Callora-Contracts Soroban workspace (
contracts/*/src/). - Run
cargo fmt,cargo clippy --all-targets --all-features -- -D warnings, andcargo testfrom the workspace root. - For WASM release builds:
cargo build --target wasm32-unknown-unknown --release -p callora-vault(adjust-pif the crate name differs).
Deliverables
lib.rs+test.rsper view.- README "What's included" sync.
Test and commit
- Run tests and
./scripts/coverage.sh(orcargo tarpaulinpertarpaulin.toml). - Cover edge cases; include summarized test output and brief security notes in the PR description.
Example commit message
docs(vault): align read-only API surface
Guidelines
- Minimum 95% line coverage for touched crates (workspace policy).
- Clear documentation (Rust
///on public items where applicable; repo markdown as needed). - Timeframe: 96 hours from assignment unless agreed otherwise.
Reactions are currently unavailable
Metadata
Metadata
Assignees
Labels
Stellar WaveIssues in the Stellar wave programIssues in the Stellar wave programsecuritysmart-contractssorobanvault