Skip to content

Fix/vault withdraw event shape#310

Merged
greatest0fallt1me merged 4 commits intoCalloraOrg:mainfrom
GEEKYFOCUS:fix/vault-withdraw-event-shape
Apr 24, 2026
Merged

Fix/vault withdraw event shape#310
greatest0fallt1me merged 4 commits intoCalloraOrg:mainfrom
GEEKYFOCUS:fix/vault-withdraw-event-shape

Conversation

@GEEKYFOCUS
Copy link
Copy Markdown

@GEEKYFOCUS GEEKYFOCUS commented Apr 24, 2026

Closes #246


  • Batch Overflow: Fixed a logic error where the test simulator would break out of the random generation loop early on an overflow without including the overflowing element. It now ensures the contract is provided with the identical overflowing payload so that the simulator and contract fail identically.
  • Vault Token Balance Overflow: Fixed a simulation limit issue where multiple maximum-allowed deposits (i128::MAX / 2) were allowed, causing the underlying USDC token balance to overflow i128::MAX. A token_sim tracker was added to prevent the test sequence from attempting deposits that breach the token standard's absolute limits.
  • Type Mismatches: Fixed type mismatches in the test suite (e.g. set_allowed_depositor) where raw Addresses were passed instead of Option<Address>.
  • Linting Compliance: Fixed an unused variable warning in contracts/settlement/src/test.rs, ensuring the entire workspace compiles seamlessly without any Clippy warnings.

🛡️ Security / Context

  • The introduction of WithdrawEventData has no impact on existing storage or balance invariant checks, but provides critical context for indexing infrastructure.
  • batch_deduct now formally requires an unpaused state, hardening the vault's emergency circuit breaker against batch deductions during an incident.

Closes(#246)

GEEKYFOCUS and others added 4 commits April 23, 2026 21:49
Standardize withdraw/withdraw_to events using a documented WithdrawEventData struct. Clean up duplicate code in lib.rs and improve fuzz test reliability by handling pause state correctly.
@greatest0fallt1me greatest0fallt1me merged commit 3aff21c into CalloraOrg:main Apr 24, 2026
0 of 3 checks passed
@GEEKYFOCUS
Copy link
Copy Markdown
Author

Hello @maintainer

This issue has been merged and closed but i'm yet to get a point

@GEEKYFOCUS
Copy link
Copy Markdown
Author

Hello Maintainer I'm yet to receive my point for the issue fixed

1 similar comment
@GEEKYFOCUS
Copy link
Copy Markdown
Author

Hello Maintainer I'm yet to receive my point for the issue fixed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Vault: emit withdraw/withdraw_to events with documented payload shape

2 participants