Firefly-849,842,845,IRSA-4224: Multiple bugs fixed#1140
Conversation
- IRSA-4224: UI covering recenter after UI changes - Firefly-849: magnified image vanish - Firefly-842: SOFIA images not centered on screen - Firefly-845: Datalink fail when image url string has a plus (+) sign
robyww
force-pushed
the
mutiple-bugs-849-842-845-i4224
branch
from
51638e5 to
269a917
Compare
|
FIREFLY-849 isn't quite fixed. Follow the steps in the ticket, and when you click the clipboard icon to copy the coordinates, the stretch on the zoom-in changes. I can't make a video for you right now because I'm attending another meeting with my Zoom, so let me know if you need a movie and I'll make one later. UPDATE here is a movie: |
|
I don't know how to test FIREFLY-845 -- if I'm reading it right, then it's fixed! IRSA-4224 is still broken. |
|
@lrebull firefly-849 nodes not have anything to do with stretch. It is about lock-by-click losing the magnified view when you click somewhere else. It appears to be fixed to me. |
|
I added a movie above. |
|
Do you want me to make another ticket for the stretch thing? |
|
IRSA-4224 also appears to be working for me. Are you sure you are testing against the firefly build listed above? |
|
am i not suppoesd to be using this one: https://fireflydev.ipac.caltech.edu/mutiple-bugs-849-842-845-i4224/firefly |
|
I'll try a "new private window" .. i thought we fixed the issue where nearly every bug I find is due to stale cookies... |
|
Both of the bugs behave exactly as in the movies i just made, but in a new private window. here's a movie for IRSA-4224 https://user-images.githubusercontent.com/23038600/137775623-d6842a48-78e4-4c88-90a5-67a61edee6dd.mp4 |
|
OK - I see the problem with firefly-849, it is not changing the stretch it is changing plots to a non-selected one when you click off. I will fix that. I guess you are going to have to demonstrate IRSA-4224 not working. To me it appears to be fixed. |
|
here's a movie for IRSA-4224 https://user-images.githubusercontent.com/23038600/137775623-d6842a48-78e4-4c88-90a5-67a61edee6dd.mp4 |
|
IRSA-4224 was broken into two tickets. #1 was related to the UI changes. That is what I am fixing here.
The #2 and #3 you moved (at my request) to IRSA-4231. They are pre-existing issues. I have not even seriously studied these two so I can't comment on them yet. Right now I am trying to fix stuff related to the UI changes. All the UI change tickets have a master ticket of https://jira.ipac.caltech.edu/browse/FIREFLY-841. |
|
Yes, I see that the center plot/recenter button is no longer buried, but it only appears at all in one image, which is not what I was expecting. I was expecting the center plot/recenter button to no longer be hidden in all four images. Should I make another new ticket just for that? |
|
When don't you just update IRSA-4231. I don't think any of that is a new behavior. I expect you can duplicate it in the production version. |
|
OK, updated. |
Firefly-845 is fixed it the tables load. Before there was an error in the DataProductViewer area. |
|
@lrebull There is a new firefly build that should fix the issue you found firefly-849. It was changing the image when you click on copy. That is why I did not see it initially, I only had one image up. https://fireflydev.ipac.caltech.edu/mutiple-bugs-849-842-845-i4224/firefly |
|
I agree, it's working now! |
robyww
force-pushed
the
mutiple-bugs-849-842-845-i4224
branch
from
dd48ba1 to
9b774ec
Compare
|
FIREFLY-842 is also fixed. |
- firefly-849: fixed: the active images changes (some poin but different image) when you click off the image - png's were not recongized in non data-link cases - firefly-845: table will votable content type were incorrectly making an error - increased direct image loading size and improved feedback more
robyww
force-pushed
the
mutiple-bugs-849-842-845-i4224
branch
from
9b774ec to
c509042
Compare
|
Yes, Firefly-845 is also fixed! Great! |
3 participants
Multiple bugs fixed
Tickets:
Testing: