Skip to content

FIREFLY-1240: flipped y axis doesn't persist in chart thumbnail view#1374

Merged
loitly merged 1 commit intorc-2023.1from
FIREFLY-1240_pinchart_flipy
May 1, 2023
Merged

FIREFLY-1240: flipped y axis doesn't persist in chart thumbnail view#1374
loitly merged 1 commit intorc-2023.1from
FIREFLY-1240_pinchart_flipy

Conversation

@loitly
Copy link
Copy Markdown
Contributor

@loitly loitly commented May 1, 2023

Ticket: https://jira.ipac.caltech.edu/browse/FIREFLY-1240
Test: https://firefly-1240-pinchart-flipy.irsakudev.ipac.caltech.edu/irsaviewer/

Also fix #10 from Bugs found in 2023.1 RC to ticket:
https://confluence.ipac.caltech.edu/display/IRSA/Bugs+found+in+2023.1+RC+%3A+IV%2C+DCE+testing+April+2023

When you use the preset function to add a column, it appears in the newly created column as true and false. But when you go to try to filter on that newly created column from the filter pulldown at the top of the new column, it says true and , not true and false. If you filter on , it does what you expect it to do, e.g., just gives you the 'false' values

- also fix boolean column with null values showing up as <NULL> in enumvals dropdown
@loitly loitly added the UI Client side UI changes not related to any of the visualizers label May 1, 2023
@loitly loitly added this to the 2023.1 milestone May 1, 2023
@loitly loitly requested a review from robyww May 1, 2023 17:30
@loitly loitly self-assigned this May 1, 2023
@robyww robyww added the bug label May 1, 2023
Copy link
Copy Markdown
Contributor

@robyww robyww left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

@lrebull
Copy link
Copy Markdown
Contributor

lrebull commented May 1, 2023

confirm, these both fixed in this build!

@loitly loitly merged commit 5e23057 into rc-2023.1 May 1, 2023
@loitly loitly deleted the FIREFLY-1240_pinchart_flipy branch May 1, 2023 17:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug UI Client side UI changes not related to any of the visualizers

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants