Skip to content

Firefly-1312,1315: hips render & Bug Fix: FITS GnomicProjection using cd matrix #1431

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Sep 19, 2023
Merged

Firefly-1312,1315: hips render & Bug Fix: FITS GnomicProjection using cd matrix #1431

merged 2 commits into from
Sep 19, 2023

Conversation

@robyww
Copy link
Contributor

@robyww robyww commented Sep 18, 2023 •
edited
Loading

Two issue: Firefly-1312 and FIREFLY-1315

Bug Fix

Testing

@robyww robyww added bug HiPS HiPS work labels Sep 18, 2023
@robyww robyww added this to the 2023.2 milestone Sep 18, 2023
@robyww robyww requested review from dencoded, gpdf and lrebull September 18, 2023 22:34
@robyww robyww self-assigned this Sep 18, 2023
@lrebull
Copy link
Contributor

lrebull commented Sep 19, 2023

ooh, this looks MUCH better!

@robyww robyww added multi-ticket This PR implements multiple Jira tickets Image FITS images labels Sep 19, 2023
@robyww robyww mentioned this pull request Sep 19, 2023
Closed
@robyww robyww changed the title Firefly-1312: hips render Firefly-1312: hips render & Bug Fix:FITS GnomicProjection using cd matrix Sep 19, 2023
@robyww robyww changed the title Firefly-1312: hips render & Bug Fix:FITS GnomicProjection using cd matrix Firefly-1312,1315: hips render & Bug Fix:FITS GnomicProjection using cd matrix Sep 19, 2023
@robyww robyww changed the title Firefly-1312,1315: hips render & Bug Fix:FITS GnomicProjection using cd matrix Firefly-1312,1315: hips render & Bug Fix: FITS GnomicProjection using cd matrix Sep 19, 2023
@robyww
Bug Fix: default the values of CD matrix to cdelt1/2 if defined
a2201bd 
  - CD1_1 or CD001001 default to CDELT1 or 0
  - CD2_2 or CD002002 default to CDELT2 or 0
@robyww robyww force-pushed the FIREFLY-1312-hips-render branch from 6524530 to a2201bd Compare September 19, 2023 16:15
@robyww robyww merged commit 6468fd5 into rc-2023.2 Sep 19, 2023
@robyww robyww deleted the FIREFLY-1312-hips-render branch September 19, 2023 16:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@gpdf gpdf Awaiting requested review from gpdf

@lrebull lrebull Awaiting requested review from lrebull

@dencoded dencoded Awaiting requested review from dencoded

Assignees

@robyww robyww

Labels

bug HiPS HiPS work Image FITS images multi-ticket This PR implements multiple Jira tickets

Projects

None yet

Milestone

2023.2

Development

Successfully merging this pull request may close these issues.

3 participants

@robyww @lrebull