Firefly-1407: response to some CCB-D feedback and #9, #10, #19, 24.5,…#1493
Merged
robyww merged 1 commit intoUI-conversionfrom Feb 6, 2024
Merged
Firefly-1407: response to some CCB-D feedback and #9, #10, #19, 24.5,…#1493robyww merged 1 commit intoUI-conversionfrom
robyww merged 1 commit intoUI-conversionfrom
Conversation
… 28.5, 54 (partial), 61 - https://confluence.ipac.caltech.edu/pages/viewpage.action?spaceKey=IRSA&title=Testing+Feb+2024+-+Joy+UI%2C+mostly - #9, #10, #19, 24.5, 28.5, 54 (partial), 61 - make checkboxes in image select panel normal text and not bold - target panel using warning color (brown) for the placeholder - File uploads will start using the warning color (brown) for buttons - plot image for images and hips will use a bolder font for title and normal font for FOV - more panels now use rounded borders (see Images panel, catalog panel, fits header, hips info, etc)
Contributor
|
9 is definitely done 10 - I straight-up admit that I am not smart enough (yet) to fully understand all the rules about what should be which color and where. I trust that you are doing it consistently, but I have also been on the Zoom for too many conversations in which the colors of various things have been debated for hours, and I just want to make sure everyone's on board with the decisions here before we all sign off on it. 19 - signing off on this one because i think this does indeed reflect my understanding of the conversation last friday. 14.5, 28.5 - fixed! 54 - fixed everywhere i checked but not TST marking 61 as done for now - we will need to continue to figure out how to make this easier for users. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Firefly-1407: response to some CCB-D feedback and 9, 10, 19, 24.5, 28.5, 54 (partial), 61
Testing
Check When confirmed