FIREFLY-1370: Implement Cascade-style plots for spectra#1499
FIREFLY-1370: Implement Cascade-style plots for spectra#1499jaladh-singhal merged 1 commit intodevfrom
Conversation
|
IANAS (I Am Not A Spectroscopist) but it does seem to be working as specified. |
loitly
left a comment
loitly
left a comment
There was a problem hiding this comment.
Great job on this nice, clean solution. However, while I was able to test successfully using your sample tables, it didn't work with another set of tables I have. I'll send them to you. I am guessing it might be related to the double negative (--) appended to the formula.
| <Stack spacing={1}> | ||
| <FormControl orientation={'horizontal'} sx={{'.MuiSwitch-root': {margin: 0}}}> | ||
| <FormLabel>Apply Cascading: </FormLabel> | ||
| <Switch checked={doCascading} onChange={(e)=>setDoCascading(e.target.checked)}/> | ||
| </FormControl> |
There was a problem hiding this comment.
If a SwitchInputField isn't already present, we should add one. It'll remove the need to handle state and populate props outside of fields.
There was a problem hiding this comment.
You can use <CheckBoxInputField type='switch'/>
There was a problem hiding this comment.
I tried using type='switch' but it doesn't allow me to enable/disable switch through UI - probably needs some debugging. Also for a single switch (instead of list of switch options), I need label on left instead of right - I think writing a SwitchInputField might be worth it. Adding this to outstanding issues ticket so that we can merge this PR.
jaladh-singhal
force-pushed
the
FIREFLY-1370-cascade-plots
branch
from
6932720 to
a0f8d61
Compare
FIREFLY-1370: Add cascading algo to combine chart FIREFLY-1370: Connect cascading algo to UI FIREFLY-1370: Fix bug when min, max are negative
jaladh-singhal
force-pushed
the
FIREFLY-1370-cascade-plots
branch
from
a0f8d61 to
ba31351
Compare
4 participants
Fixes FIREFLY-1370
Adds cascading option to combine chart dialog which makes sure that plots don't overlap when combined.
Note: I changed two icon in chart panel's pinned mode (feel free to suggest better icons):
Testing
https://fireflydev.ipac.caltech.edu/firefly-1370-cascade-plots/firefly
This achieves what design ticket is asking for, but more testing is needed to find out the edge cases where it will fail.