Conversation
jaladh-singhal
left a comment
jaladh-singhal
left a comment
There was a problem hiding this comment.
Looks good. Tested all 5 points and they work as expected!
The user-added column still still shows up red/brown (FIREFLY-1479 #2) - not sure if this was supposed to be fixed too?
| {/*{showUnits && <Box height='1em'/>}*/} | ||
| {/*{showTypes && <Box height='1em'/>}*/} | ||
| {showFilters && <FilterButton iconButtonSize='32px' | ||
| {showFilters && <FilterButton iconButtonSize='28px' |
There was a problem hiding this comment.
Might consider changing this to rem units if it makes sense.
There was a problem hiding this comment.
Probably not. The table library used is fixed-data-table. Everything is in pixel size.
|
This is probably out of scope of this PR but might be an easy fix: Clicking full text on some rows - brings full text dialog with width extending beyond viewport. I think it requires a max width setting and overflow prop to show scroll bars. |
|
FIREFLY-1479 - delete button fixed, as is colors in the new column in various places, though I note they're not the same shade of brown in the various renditions of the table (in the main tri-view, the new column is a light brown; in table options, they're more of a ruddy brown, at least on my screen, which has been shown in the past to be defective when it comes to colors). this is fine, though, if y'all are ok with this. FIREFLY-1478 #5 in FIREFLY-1484 - fixed as far as i can tell FIREFLY-1478 #9 in FIREFLY-1484 - I can't figure out what @gpdf was looking at to test this! I am going to ask him. FIREFLY-1478 #10 in FIREFLY-1484 - The label now says "full text" instead of "plain text". |
|
Loi pointed me towards the Gaia TAP server to find examples to test the 'view as text' options. Definitely an improvement over before, but this looks really ...odd, especially if you don't know to look for the '...' on the right of the over-full fields. |
|
Not sure how to test "Single-column numeric tables don't auto-size correctly" |
4 participants
https://jira.ipac.caltech.edu/browse/FIREFLY-1481
https://jira.ipac.caltech.edu/browse/FIREFLY-1484
https://jira.ipac.caltech.edu/browse/FIREFLY-1479
#5Table column header vertical alignment adjustments#10Change label 'View as plain text' to 'View full text'#9View full text with formatting should render html tags as HTMLTest: https://fireflydev.ipac.caltech.edu/firefly-1481-single-column-resize/firefly/
Follow the instructions in the tickets to test