Skip to content

FIREFLY-1504: Update plotly to latest version#1579

Merged
jaladh-singhal merged 1 commit intodevfrom
FIREFLY-1504-plotly-update
Jun 28, 2024
Merged

FIREFLY-1504: Update plotly to latest version#1579
jaladh-singhal merged 1 commit intodevfrom
FIREFLY-1504-plotly-update

Conversation

@jaladh-singhal
Copy link
Copy Markdown
Member

Fixes FIREFLY-1504

Testing

https://fireflydev.ipac.caltech.edu/firefly-1504-plotly-update/firefly/

test that the charts in the following look the same:

  • /test/tests-chart.html
  • any TAP or catalog search
  • firefly_client example notebooks

Can also track networks tab (filtered by "JS") to see that plotly-2.32.0.min.js is loaded

@jaladh-singhal jaladh-singhal added dependencies Pull requests that update a dependency file Charts Anything related to charts labels Jun 26, 2024
@jaladh-singhal jaladh-singhal added this to the 2024.3 milestone Jun 26, 2024
@jaladh-singhal jaladh-singhal requested review from loitly and robyww June 26, 2024 22:56
@jaladh-singhal jaladh-singhal self-assigned this Jun 26, 2024
Copy link
Copy Markdown
Contributor

@loitly loitly left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested. Looks good.

Copy link
Copy Markdown
Contributor

@robyww robyww left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

@jaladh-singhal jaladh-singhal merged commit 4411481 into dev Jun 28, 2024
@jaladh-singhal jaladh-singhal deleted the FIREFLY-1504-plotly-update branch June 28, 2024 02:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Charts Anything related to charts dependencies Pull requests that update a dependency file

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants