Skip to content

Firefly-1503: Update eslint, node and other dependencies#1581

Merged
jaladh-singhal merged 5 commits intodevfrom
FIREFLY-1503-eslint-update
Jul 2, 2024
Merged

Firefly-1503: Update eslint, node and other dependencies#1581
jaladh-singhal merged 5 commits intodevfrom
FIREFLY-1503-eslint-update

Conversation

@jaladh-singhal
Copy link
Member

@jaladh-singhal jaladh-singhal commented Jul 2, 2024

Fixes FIREFLY-1503

  • Updated eslint and related dependencies (eslint plugins)
  • Replaced .eslintrc by eslint.config.mjs using Eslint 9 configuration migrator. Additional modifications:
    • Made it work with both js and jsx
    • Ignore gitignored files
    • Fixed deprecated rules (now available through @stylistic/js pacakge)
    • Reordered and regrouped rules based on plugins
  • Upgraded node version in Dockerfile and readme
  • Upgraded dependencies with vulnerability warnings: webpack, @babel/core - also updated related packages of babel
  • Updated documentation to update package.json: https://github.com/IPAC-SW/irsa-ife/pull/338

Testing

@jaladh-singhal jaladh-singhal added enhancement dependencies Pull requests that update a dependency file labels Jul 2, 2024
@jaladh-singhal jaladh-singhal added this to the 2024.3 milestone Jul 2, 2024
@jaladh-singhal jaladh-singhal requested review from loitly and robyww July 2, 2024 03:13
@jaladh-singhal jaladh-singhal self-assigned this Jul 2, 2024
Copy link
Contributor

@robyww robyww left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks good and works.

@jaladh-singhal jaladh-singhal merged commit a781a21 into dev Jul 2, 2024
@jaladh-singhal jaladh-singhal deleted the FIREFLY-1503-eslint-update branch July 2, 2024 20:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

dependencies Pull requests that update a dependency file enhancement Infrastructure

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants