Skip to content

FIREFLY-1516: The chart is not recognizing short as a numeric type#1595

Merged
loitly merged 1 commit intodevfrom
FIREFLY-1516-chart-numeric-columns
Jul 25, 2024
Merged

FIREFLY-1516: The chart is not recognizing short as a numeric type#1595
loitly merged 1 commit intodevfrom
FIREFLY-1516-chart-numeric-columns

Conversation

@loitly
Copy link
Copy Markdown
Contributor

@loitly loitly commented Jul 24, 2024

Ticket: https://jira.ipac.caltech.edu/browse/FIREFLY-1516
I added a test file to the ticket to show that the chart will recognize short as a numeric type.
The test table also includes an unsignedByte column to address the question raised in the ticket.

Test: https://fireflydev.ipac.caltech.edu/firefly-1516-chart-numeric-columns/firefly/

@loitly loitly added the Charts Anything related to charts label Jul 24, 2024
@loitly loitly added this to the 2024.3 milestone Jul 24, 2024
@loitly loitly requested review from gpdf and robyww July 24, 2024 16:28
@loitly loitly self-assigned this Jul 24, 2024
Copy link
Copy Markdown
Contributor

@robyww robyww left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

@loitly loitly merged commit 5d0e4c0 into dev Jul 25, 2024
@loitly loitly deleted the FIREFLY-1516-chart-numeric-columns branch July 25, 2024 17:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Charts Anything related to charts

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants