Firefly-1537: implement hierarchical catalogs#1607
Conversation
|
Here are the results of my testing. Test: Load Big Table
All tests below are based on this table. Test: Zoom and Pan
Test: Min Group
Test: Highlight a Row from Table or Images
Test: Clicking on a Group Expands It Until You Scroll or Zoom
Test: Select an Area and Click the "Mark Data as Selected" Button
|
|
Ok, just trying things out here, so just noting what I'm seeing, sort of stream-of-consciousness, for better or worse... On the whole, I really, really like this a lot, and I can't wait for this to be widely available. Uploaded three massive catalogs (well, two HUGE and one smaller). They loaded pretty quickly, all things considered, but all of them have come up with red squares, so the first thing I have to do is pull up layers and change colors. (see screenshot 1) Even the smaller catalog is represented the same way as the big catalogs, which I initially didn't expect, but that does make sense. I just need to remember to highlight this to users who may be conditioned now to making catalogs under the 5000 source limit. I didn't expect some ellipses (as opposed to all circles) as I zoomed in, but I guess that makes sense given the non-uniform tiles? screenshot 2. Why are some individual sources shown here? is it because those cells are sparse enough that it has decided to show the individual sources? Empirically, I'm trying the "min group" thing, and I'm thinking this must be the minimum number of sources in a 'cell' before it turns into a cell, but I'm not 100% sure of that. Is that what it is? We need a tooltip; I can help with wording if I understand what it's doing. When you have multiple catalogs overlaid, the numbers of sources in a 'cell' are overwritten right on top of each other. I'm not sure there is a solution to this. (screenshot 3) It doesn't look like tooltips work here (e.g. like plots do when you mouseover a point). Ooh, THIS feature is really cool. (screenshot 4) I didn't expect this! I don't know what causes it to redraw it as a cell though. I first thought it was once I clicked in a different healpix cell, but empirically that's not the case. It just seems to randomly decide, oh, now i'll re-render it as a bin rather than individual points. And it only works if you click within the circle, not outside a circle, which is unexpected, especially if I have an individually rendered source from one catalog outside a circle, but everything else from the other two catalogs shown as a circle. This really is cool! I'm sure the others will have feedback too. |
2893a54 to
100807e
Compare
|
I have a hastily scribbled note to myself that you wanted me to test this again but i can't tell from the stuff here if you are ready for me to test it again or not ...? |
|
@lrebull try:
|
|
WOW the multiple catalog handling looks REALLY good now! SO COOL when do we get it on ops?? i would like to test this in finder chart because i bet that will break all sorts of things ... |
Only just got around to testing this as I was occupied with Euclid, this looks great! I think most (if not all) of the bugs @loitly encountered have since been resolved, I tested mostly according to his testing flow above and this latest update. I was also confused by Min Group (and I think I still am - that's the only one I didn't properly understand, but I think that's on me). Played around for a while, zooming/panning, expanding groups, etc. Didn't crash/freeze for me. Tried out the different grouping types, clicked anywhere in the |
a97b1f3 to
310577e
Compare
|
OOh! OK, trying FC. I did the thing where I upload enormous catalogs again, because that's my most stressful use case. NEVERMIND I TAKE IT BACK THIS IS THE REAL EDGE OF THE CATALOG. It does.. this. which is weird. it looks like i've zoomed in enough to get the individual sources from one cell but not an adjacent cell? i don't know, it's ...strange. catalog files attached as a tarfile. i uploaded "ysolist.tbl" as the multiple position search with everything set as the defaults, and then overlaid the two other catalogs (entire*tbl) and zoomed in on the first source in the list until I could see individual sources. UPDATE: still happens for me in 'new private window.' |
|
This is really cool. It seems to work pretty well for me! |
|
The color swatches on the catalog tabs are missing, FYI. |
| } | ||
|
|
||
| private static void populateToLittleEndianbyte(long v, byte[] raByteAry, int bIdx) { | ||
| byte[] bAry= (new BigInteger(v+"")).toByteArray(); |
There was a problem hiding this comment.
If performance matters, you should use BigInteger.valueOf(v) instead.
| var inclColStr= tsr.getInclColumns(); | ||
| var cAry= Arrays | ||
| .stream(inclColStr.split(",")) | ||
| .map( (s) -> s.charAt(0)=='"' && s.charAt(s.length()-1)=='"' ? s.substring(1, s.length()-1) : s ) | ||
| .toList(); | ||
|
|
||
| if (cAry.size()<2) return; |
There was a problem hiding this comment.
Here, you extract ra/dec from the includeColumns field with assumption that ra is in index 0, then dec at 1 later down the road, accounting for quoted syntax used by SQL.
You could have made 'ra' / 'dec' parameters, then setInclColumns with those values. This make the request more clear, making it easier to validate as well.
2c4d872 to
db55563
Compare





Firefly-1537: Hierarchical catalogs
Testing
Firefly
FinderChart