FIREFLY-1592: Directly import IPAC table data into the database#1667
Merged
FIREFLY-1592: Directly import IPAC table data into the database#1667
Conversation
Contributor
|
My tests results:
|
kpuriIpac
approved these changes
Nov 12, 2024
Contributor
kpuriIpac
left a comment
There was a problem hiding this comment.
I skimmed through the code, got the gist of it (but don't understand it deeply enough). Code changes in addition to the testing and speed improvement, overall looks good!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Ticket: https://jira.ipac.caltech.edu/browse/FIREFLY-1592
See ticket for details.
In the past, handling large tables required more memory. This PR should improve that.
Test: https://fireflydev.ipac.caltech.edu/firefly-1592-ipactable-direct-ingest/firefly/
If you need a test file, you can use this one: a 3 million row, 25 column, 1.2GB IPAC table file. https://irsadev.ipac.caltech.edu:9201/test/3mil.tbl (Upload via URL)
From DevTools, I see that my PR build takes 21.4s, compared to 28.2s for nightly. On the nightly build, it seems to crash (or possibly fails to load) on hips coverage, as it sometimes doesn't show up. Both PR and nightly are running with 4GB of memory.