Skip to content

FIREFLY-1592: Directly import IPAC table data into the database#1667

Merged
loitly merged 1 commit intodevfrom
FIREFLY-1592-ipactable-direct-ingest
Nov 14, 2024
Merged

FIREFLY-1592: Directly import IPAC table data into the database#1667
loitly merged 1 commit intodevfrom
FIREFLY-1592-ipactable-direct-ingest

Conversation

@loitly
Copy link
Contributor

@loitly loitly commented Nov 7, 2024

Ticket: https://jira.ipac.caltech.edu/browse/FIREFLY-1592
See ticket for details.

In the past, handling large tables required more memory. This PR should improve that.
Test: https://fireflydev.ipac.caltech.edu/firefly-1592-ipactable-direct-ingest/firefly/

  • Upload a large IPAC table

If you need a test file, you can use this one: a 3 million row, 25 column, 1.2GB IPAC table file. https://irsadev.ipac.caltech.edu:9201/test/3mil.tbl (Upload via URL)

From DevTools, I see that my PR build takes 21.4s, compared to 28.2s for nightly. On the nightly build, it seems to crash (or possibly fails to load) on hips coverage, as it sometimes doesn't show up. Both PR and nightly are running with 4GB of memory.

@loitly loitly added this to the 2024.4 milestone Nov 7, 2024
@loitly loitly requested a review from kpuriIpac November 7, 2024 19:49
@loitly loitly self-assigned this Nov 7, 2024
@loitly loitly added the Table Changes to table or table model label Nov 8, 2024
@kpuriIpac
Copy link
Contributor

My tests results:

  • I ran both your test build and nightly (I used irsaviewer upload) a few times, disabled cache, and here's the avg times I got:
    • PR test build: ~23 sec
    • Nightly Irsaviewer: ~30 sec
  • So definitely an improvement! Taking a brief look at the code now, but other than that this looks good.

Copy link
Contributor

@kpuriIpac kpuriIpac left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I skimmed through the code, got the gist of it (but don't understand it deeply enough). Code changes in addition to the testing and speed improvement, overall looks good!

@loitly loitly merged commit 1aca993 into dev Nov 14, 2024
@loitly loitly deleted the FIREFLY-1592-ipactable-direct-ingest branch November 14, 2024 22:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Table Changes to table or table model

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants