FIREFLY-1635: bug fix for CADC prepare download#1683
Merged
Conversation
kpuriIpac
commented
Dec 17, 2024
| function updateSearchRequest( tbl_id='', dlParams='', sRequest=null) { | ||
| const hostname= new URL(sRequest.source)?.hostname; | ||
|
|
||
| const hostname= new URL(sRequest.source ? sRequest.source : sRequest.serviceUrl)?.hostname; |
Contributor
Author
There was a problem hiding this comment.
actually I can just simply this to sRequest.source ?? sRequest.serviceUrl. I'll add that in tomorrow, but let me know if it looks good & if testing it works for both CADC / DCE @robyww.
Contributor
|
doesn't work for me; see attached movie. screenshot is the error i get (which is before downloading attempt). tbl file with target list also attached. 
video1110386765.mp4 |
kpuriIpac
force-pushed
the
FIREFLY-1635-prepare-download-bug
branch
from
704e01a to
6798c7c
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Ticket: FIREFLY-1635
ttFeatureWatchers.js, in some cases the request object does not have asourceentry, but will have aserviceUrlentry instead (from TAP).sourceis undefined, fixing thePrepare Downloadnot working for CADC bugTesting:
Firefly: https://fireflydev.ipac.caltech.edu/firefly-1635-prepare-download-bug/firefly
DCE: https://firefly-1635-prepare-download-bug.irsakudev.ipac.caltech.edu/irsaviewer/dce
Prepare Downloadto make sure it worksPrepare Downloadhaving selected one or more rows).