IRSA-6747: Changes in the job-submission UI#1739
Merged
jaladh-singhal merged 2 commits intodevfrom Apr 9, 2025
Merged
Conversation
77b4d83 to
be99fa9
Compare
robyww
requested changes
Apr 8, 2025
Contributor
robyww
left a comment
There was a problem hiding this comment.
Most of the code looks good but I would like you to do some clean up on how we handle target feedback. I put the comment below we can talk if they are unclear.
robyww
approved these changes
Apr 9, 2025
kpuriIpac
approved these changes
Apr 9, 2025
Contributor
kpuriIpac
left a comment
There was a problem hiding this comment.
Looks good! Tested changes according to ticket, and tested Euclid / DCE as well. The summary looks much cleaner now.
IRSA-6747: Make time range panel popup title same as labels IRSA-6747: Remove hours, min from ExposureSince in LVF IRSA-6747: Remove wavelength coverage label from filter options Make wavelength range fixed to overlaps IRSA-6747: Rename spectrophotometry complete button to 'Submit'
IRSA-6747: Minimize search summary EmbeddedPositionSearchPanel.jsx IRSA-6747: Cleanup coordinate formatting logic as per Trey's comments
f1eba45 to
b9a2ba0
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes IRSA-6747
See IFE PR: https://github.com/IPAC-SW/irsa-ife/pull/401
Testing
https://irsa-6747-specphot-updates.irsakudev.ipac.caltech.edu/applications/spherex
Regression testing
https://irsa-6747-specphot-updates.irsakudev.ipac.caltech.edu/applications/euclid
https://irsa-6747-specphot-updates.irsakudev.ipac.caltech.edu/irsaviewer
Check Search summary for Euclid and DCE uses of EmbeddedSearchPositionPanel