Skip to content

IRSA-6747: Changes in the job-submission UI#1739

Merged
jaladh-singhal merged 2 commits intodevfrom
IRSA-6747-specphot-updates
Apr 9, 2025
Merged

IRSA-6747: Changes in the job-submission UI#1739
jaladh-singhal merged 2 commits intodevfrom
IRSA-6747-specphot-updates

Conversation

@jaladh-singhal
Copy link
Member

@jaladh-singhal jaladh-singhal commented Apr 5, 2025

Fixes IRSA-6747

See IFE PR: https://github.com/IPAC-SW/irsa-ife/pull/401

  • Mostly wording changes
  • Make WavelengthOptions more customizable - fixed vs selectable range type, filter definitions label can be changed
  • Major change in Search Summary of EmbeddedSearchPositionPanel: instead of key value pairs, it appears as a much shorter string now (no resolver name, and hms or dcm is chosen from HiPS readout preference)

Testing

https://irsa-6747-specphot-updates.irsakudev.ipac.caltech.edu/applications/spherex

  • Check if all wordings have been changed as per ticket
  • Check Spectrophotometry form's wavelength options
  • Try all 3 cases (Cone, polygon, multi-object) in LVF search form and collapse the form to check search summary. Similarly check 2 cases (point and multi-object) in Spectrophotometry tool

Regression testing

https://irsa-6747-specphot-updates.irsakudev.ipac.caltech.edu/applications/euclid

https://irsa-6747-specphot-updates.irsakudev.ipac.caltech.edu/irsaviewer

Check Search summary for Euclid and DCE uses of EmbeddedSearchPositionPanel

@jaladh-singhal jaladh-singhal self-assigned this Apr 5, 2025
@jaladh-singhal jaladh-singhal added enhancement UI Client side UI changes not related to any of the visualizers labels Apr 5, 2025
@jaladh-singhal jaladh-singhal added this to the 2025.3 milestone Apr 5, 2025
@jaladh-singhal jaladh-singhal force-pushed the IRSA-6747-specphot-updates branch from 77b4d83 to be99fa9 Compare April 7, 2025 18:10
Copy link
Contributor

@robyww robyww left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Most of the code looks good but I would like you to do some clean up on how we handle target feedback. I put the comment below we can talk if they are unclear.

@jaladh-singhal jaladh-singhal requested a review from robyww April 9, 2025 02:00
Copy link
Contributor

@kpuriIpac kpuriIpac left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Tested changes according to ticket, and tested Euclid / DCE as well. The summary looks much cleaner now.

IRSA-6747: Make time range panel popup title same as labels

IRSA-6747: Remove hours, min from ExposureSince in LVF

IRSA-6747: Remove wavelength coverage label from filter options

Make wavelength range fixed to overlaps

IRSA-6747: Rename spectrophotometry complete button to 'Submit'
IRSA-6747: Minimize search summary EmbeddedPositionSearchPanel.jsx

IRSA-6747: Cleanup coordinate formatting logic as per Trey's comments
@jaladh-singhal jaladh-singhal force-pushed the IRSA-6747-specphot-updates branch from f1eba45 to b9a2ba0 Compare April 9, 2025 20:39
@jaladh-singhal jaladh-singhal merged commit 5aa95f6 into dev Apr 9, 2025
@jaladh-singhal jaladh-singhal deleted the IRSA-6747-specphot-updates branch April 9, 2025 20:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement UI Client side UI changes not related to any of the visualizers

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants