Skip to content

Firefly-1706, Firefly-1195: fixed two tickets#1744

Merged
robyww merged 3 commits intodevfrom
FIREFLY-1706-tap-search-selection
Apr 23, 2025
Merged

Firefly-1706, Firefly-1195: fixed two tickets#1744
robyww merged 3 commits intodevfrom
FIREFLY-1706-tap-search-selection

Conversation

@robyww
Copy link
Contributor

@robyww robyww commented Apr 22, 2025

Firefly-1706, Firefly-1195: fixed two tickets

  • Firefly-1195: refine search region stays on when it shouldn't
    • Search refinment: also fixes cone sizing is wrong which switch from polygon
    • Search refinment: polygon will not reselect once it is selected once
  • Firefly-1706: TAP search from selection tool is broken

Testing

Confirmed

  - Firefly-1195: refine search region stays on when it shouldn't
     - Search refinment: also fixes cone sizing is wrong which switch from polygon
     - Search refinment: polygon will not reselect once it is selected once
  - Firefly-1706: TAP search from selection tool is broken
@robyww robyww added bug multi-ticket This PR implements multiple Jira tickets labels Apr 22, 2025
@robyww robyww added this to the 2025.3 milestone Apr 22, 2025
@robyww robyww requested a review from lrebull April 22, 2025 21:30
@robyww robyww self-assigned this Apr 22, 2025
@lrebull
Copy link
Contributor

lrebull commented Apr 23, 2025

1195 is fixed but 1706 is still broken for me. do you want a movie?

@lrebull
Copy link
Contributor

lrebull commented Apr 23, 2025

video1375405559.mp4

video attached. it's less broken than i thought it was, but still broken (for me). maybe it's related to GLIMPSE images??

@robyww robyww merged commit 4ffe305 into dev Apr 23, 2025
@robyww robyww deleted the FIREFLY-1706-tap-search-selection branch April 23, 2025 22:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug multi-ticket This PR implements multiple Jira tickets

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants