Firefly-1718: Better handle data product catalog that connect to images#1747
Merged
Firefly-1718: Better handle data product catalog that connect to images#1747
Conversation
Contributor
|
That's nice! Works great to address what I was seeing. |
robyww
force-pushed
the
FIREFLY-1718-hightlight-change
branch
from
343fb90 to
2983936
Compare
kpuriIpac
approved these changes
Apr 25, 2025
Contributor
kpuriIpac
left a comment
kpuriIpac
left a comment
There was a problem hiding this comment.
Looks great! Really neat feature. Just one comment with a suggestion below.
|
|
||
| useEffect(() => { | ||
| setVisible(true); | ||
| const id= setTimeout(() => setVisible(false),5000); |
Contributor
There was a problem hiding this comment.
I think we should increase the timeout to 10 or 15 seconds. When the text came up, by the time I noticed and read it, it disappeared (the first few times). It might be better to leave it on there a little longer.
robyww
force-pushed
the
FIREFLY-1718-hightlight-change
branch
from
37a34ef to
97c56a9
Compare
- show scroll image indicator when width is greater then height - includes response to feedback
robyww
force-pushed
the
FIREFLY-1718-hightlight-change
branch
from
97c56a9 to
c7baa35
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Firefly-1718: Better handle data product catalog that connect to images
Testing
Inspect Objectssearch