Firefly-1733: Improve file analysis handling, cleaned up many outstanding loose ends#1759
Firefly-1733: Improve file analysis handling, cleaned up many outstanding loose ends#1759
Conversation
robyww
added
bug
UI
robyww
force-pushed
the
FIREFLY-1733-analysis
branch
from
39e698d to
13bfde5
Compare
kpuriIpac
left a comment
kpuriIpac
left a comment
There was a problem hiding this comment.
Looking mostly good! You were right, lots of changes so I was not able to go through all of the code but just skim over it. Tested all apps, file uploads seem to work well, didn't really find anything broken in existing behavior.
I found one bug, though. Tried a CADC search in firefly, in the Data Product Viewer, click on More and then select cutout. If you try to edit the BAND field value, you get this error (even if you keep it the same as the default, which is 0).
The exact search I did: CADC -> IVOA -> m81, Row Limit:50, try the first row (obs_collection HST). I think you basically need a cutout to test this.
kpuriIpac
left a comment
kpuriIpac
left a comment
There was a problem hiding this comment.
Let me know if you want me to specifically test any other behavior in any of the apps.
| const doResetButton= displayType!==DPtypes.ANALYZE && !isWorkingState && Boolean(searchParams || serDef?.serDefParams?.some( (sdp) => !sdp.ref)); | ||
|
|
||
| const getInput= displayType===DPtypes.ANALYZE && allowsInput && !searchParams; | ||
| // if (isDefined(serDescActive)) getInput= !serDescActive; |
There was a problem hiding this comment.
might be cleaned up and removed
robyww
force-pushed
the
FIREFLY-1733-analysis
branch
2 times, most recently
from
95b6c36 to
b5e1ee1
Compare
…d loose ends
- Spectrum analysis now happens during file analysis
- Mostly used for MultiProductViewer
- FileUploadViewPanel is slightly smarter
- Removed unused "strategy" from FITSTableReader
- better handle mulitple service descriptor
- user can control if a service descriptor defaults to activate or enter paramters
- better error messages when data is not found
- Improved analysis of when to automatically call a service descriptor
- Better handling of catalog files with more than one service descriptor
- Clean up dataTypeHint, removed unnecessary parameters
- TAP
- Fixed tap schema and table navigation
- for reporting issues: A TAP UWS call will now log a sychronous version url
- Also fixes: Firefly-1732
- Also fiuxes Firefly-1728: update MAST TAP url
- Also improves wording layout in CoverageViewer
- includes response to feedback
robyww
force-pushed
the
FIREFLY-1733-analysis
branch
from
b5e1ee1 to
5ceb780
Compare
2 participants
Firefly-1733: Improve file analysis handling, cleaned up many outstanding loose ends
Testing