IRSA-6898: SPHEREx: Reconcile LVF and Spectrophotometry Results#1769
Merged
jaladh-singhal merged 3 commits intodevfrom May 21, 2025
Merged
IRSA-6898: SPHEREx: Reconcile LVF and Spectrophotometry Results#1769jaladh-singhal merged 3 commits intodevfrom
jaladh-singhal merged 3 commits intodevfrom
Conversation
robyww
approved these changes
May 20, 2025
Contributor
robyww
left a comment
There was a problem hiding this comment.
Looks good. I like you improvements on DockLayoutPanel
loitly
approved these changes
May 20, 2025
IRSA-6898: Conditionally create triview if spectrophotometry table present Prevent ImageTableRowViewer not loading after LVF search since dataProductsFactoryOptions don't go through IRSA-6898: Make SplitContent collapsible IRSA-6898: Improve error handling and styling in ImageTableRowViewer and ResultsViewer IRSA-6898: Generalize SplitContent with a toggle button in its own component IRSA-6898: Polish the collapsing behavior
IRSA-6898: Improve loading state handling in SpectrumImagesViewer, and cleanup IRSA-6898: define default error message in ImageTableRowViewer
…SplitPanel IRSA-6898: Make collapsible rendering a prop of SplitContent
3667421 to
847607b
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes IRSA-6898
See ife PR: https://github.com/IPAC-SW/irsa-ife/pull/412