Skip to content

IRSA-6898: SPHEREx: Reconcile LVF and Spectrophotometry Results#1769

Merged
jaladh-singhal merged 3 commits intodevfrom
IRSA-6898-reconcile-spherex-results
May 21, 2025
Merged

IRSA-6898: SPHEREx: Reconcile LVF and Spectrophotometry Results#1769
jaladh-singhal merged 3 commits intodevfrom
IRSA-6898-reconcile-spherex-results

Conversation

@jaladh-singhal
Copy link
Member

Fixes IRSA-6898

See ife PR: https://github.com/IPAC-SW/irsa-ife/pull/412

Note: I've tried to generalize the collapsible split panel components used in spherex results but the still need more work to make the styling not specific to spherex use case - left those as TODOs in code.

@jaladh-singhal jaladh-singhal added this to the 2025.3 milestone May 19, 2025
@jaladh-singhal jaladh-singhal requested review from loitly and robyww May 19, 2025 23:44
@jaladh-singhal jaladh-singhal self-assigned this May 19, 2025
@jaladh-singhal jaladh-singhal added enhancement UI Client side UI changes not related to any of the visualizers labels May 19, 2025
Copy link
Contributor

@robyww robyww left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. I like you improvements on DockLayoutPanel

@jaladh-singhal jaladh-singhal changed the title Irsa 6898 reconcile spherex results IRSA-6898: SPHEREx: Reconcile LVF and Spectrophotometry Results May 20, 2025
IRSA-6898: Conditionally create triview if spectrophotometry table present

Prevent ImageTableRowViewer not loading after LVF search since dataProductsFactoryOptions don't go through

IRSA-6898: Make SplitContent collapsible

IRSA-6898: Improve error handling and styling in ImageTableRowViewer and ResultsViewer

IRSA-6898: Generalize SplitContent with a toggle button in its own component

IRSA-6898: Polish the collapsing behavior
IRSA-6898: Improve loading state handling in SpectrumImagesViewer, and cleanup

IRSA-6898: define default error message in ImageTableRowViewer
…SplitPanel

IRSA-6898: Make collapsible rendering a prop of SplitContent
@jaladh-singhal jaladh-singhal force-pushed the IRSA-6898-reconcile-spherex-results branch from 3667421 to 847607b Compare May 21, 2025 19:44
@jaladh-singhal jaladh-singhal merged commit 5985c72 into dev May 21, 2025
@jaladh-singhal jaladh-singhal deleted the IRSA-6898-reconcile-spherex-results branch May 21, 2025 19:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement UI Client side UI changes not related to any of the visualizers

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants