Skip to content

FIREFLY-1265: Table column filter misinterpret 'NOT LIKE'.#1773

Merged
loitly merged 1 commit intodevfrom
FIREFLY-1265-filter-not-like
May 27, 2025
Merged

FIREFLY-1265: Table column filter misinterpret 'NOT LIKE'.#1773
loitly merged 1 commit intodevfrom
FIREFLY-1265-filter-not-like

Conversation

@loitly
Copy link
Contributor

@loitly loitly commented May 27, 2025

Ticket: https://jira.ipac.caltech.edu/browse/FIREFLY-1265

  • added support for NOT IN as well.

From ticket:

There's a bug in table's column filtering. Using NOT LIKE just results in the 'not' being dropped. i.e. "NOT LIKE Kepler" , after hitting enter, becomes "like '%Kepler%'".

NOT LIKE is standard SQL and should be supported. The bug is probably a result of 'auto correct' in FilterInfo.

To test: https://fireflydev.ipac.caltech.edu/firefly-1265-filter-not-like/firefly

  • Load any table
  • In a string column, enter 'not like [anything]', then 'Enter' or tab away
  • It should work and not report an error.

@loitly loitly added this to the 2025.3 milestone May 27, 2025
@loitly loitly requested a review from kpuriIpac May 27, 2025 16:56
@loitly loitly self-assigned this May 27, 2025
@loitly loitly added the bug label May 27, 2025
@loitly loitly merged commit 229df94 into dev May 27, 2025
@loitly loitly deleted the FIREFLY-1265-filter-not-like branch May 27, 2025 22:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants