fix position not updating for downloads#1840
Closed
Conversation
kpuriIpac
commented
Sep 11, 2025
Comment on lines
200
to
+206
| if (pointIn(drawObj.pts, positionWP)) return result; | ||
| const fallback = makeWorldPtUsingCenterColumns(table, row); | ||
| return {requestedType: result.requestedType, foundType: fallback ? ROW_POSITION : undefined, positionWP: fallback}; | ||
| return { | ||
| requestedType: result?.requestedType, | ||
| foundType: result?.foundType ?? (fallback ? ROW_POSITION : undefined), | ||
| positionWP: result?.positionWP ?? (fallback || undefined) | ||
| }; |
Contributor
Author
There was a problem hiding this comment.
Never mind, I don't need this code. I'll close this PR.
The only use case was that if the user enters a position (user entered position) that fails the pointIn(drawObj.pts, positionWP) (returns false), then we fallback to the ROW_POSITION. But I think that's intentional, right? In that case, I don't need to add this code.
Can you confirm @robyww?
(I can confirm the bug is fixed even without this change, and just with the IFE change. I built the Jenkins builds as well with only the rc-2025.4 branch and IFE feature branch)
Contributor
Author
|
these changes are not needed |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.